r88556 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88555‎ | r88556 | r88557 >
Date:23:34, 21 May 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 26240) CodeReview's (partially absence of) query params suck (tracking)

$suckage--;

Switch default list view to use query params, rather than all the /foo/bar, they are kept around for pretty links
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -353,8 +353,9 @@
354354 if ( $this->mView->mAuthor ) {
355355 $options['author'] = $this->mView->mAuthor;
356356 }
 357+ $options['status'] = $value;
357358 return $this->mView->skin->link(
358 - SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/status/' . $value ),
 359+ SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() ),
359360 htmlspecialchars( $this->mView->statusDesc( $value ) ),
360361 array(),
361362 $options
@@ -364,7 +365,13 @@
365366 if ( $this->mView->mStatus ) {
366367 $options['status'] = $this->mView->mStatus;
367368 }
368 - return $this->mView->authorLink( $value, $options );
 369+ $options['author'] = $value;
 370+ return $this->mView->skin->link(
 371+ SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() ),
 372+ htmlspecialchars( $value ),
 373+ array(),
 374+ $options
 375+ );
369376 case 'cr_message':
370377 return $this->mView->messageFragment( $value );
371378 case 'cr_timestamp':

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88551* (bug 26240) CodeReview's (partially absence of) query params suck (tracking)...reedy22:44, 21 May 2011

Status & tagging log