r88552 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88551‎ | r88552 | r88553 >
Date:22:47, 21 May 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r88551, add some more filtering parameters to be used
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -379,16 +379,21 @@
380380 }
381381 case 'cr_path':
382382 $title = $this->mRepo->getName();
 383+
 384+ $options = array( 'path' => (string)$value );
383385 if( $this->mView->mAuthor ) {
384 - $title .= '/author/' . $this->mView->mAuthor;
 386+ $options['author'] = $this->mView->mAuthor;
385387 }
 388+ if ( $this->mView->mStatus ) {
 389+ $options['status'] = $this->mView->mStatus;
 390+ }
386391
387392 return Xml::openElement( 'div', array( 'title' => (string)$value ) ) .
388393 $this->mView->skin->link(
389394 SpecialPage::getTitleFor( 'Code', $title ),
390395 $wgLang->truncate( (string)$value, 50 ),
391396 array( 'title' => (string)$value ),
392 - array( 'path' => (string)$value )
 397+ $options
393398 ) . "</div>";
394399 }
395400 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88551* (bug 26240) CodeReview's (partially absence of) query params suck (tracking)...reedy22:44, 21 May 2011

Status & tagging log