r87454 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87453‎ | r87454 | r87455 >
Date:21:20, 4 May 2011
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Using $wgUser->getSkin() to call link() instead of Linker:: - fixes backwards compatibility issues
Modified paths:
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -172,13 +172,13 @@
173173 * @return String: HTML table of recent lows
174174 */
175175 protected function renderRecentLows() {
176 - global $wgOut, $wgArticleFeedbackRatings;
 176+ global $wgOut, $wgUser, $wgArticleFeedbackRatings;
177177
178178 $rows = array();
179179 foreach ( $this->getRecentLows() as $page ) {
180180 $row = array();
181181 $pageTitle = Title::newFromText( $page['page'] );
182 - $row['page'] = Linker::link( $pageTitle, $pageTitle->getPrefixedText() );
 182+ $row['page'] = $wgUser->getSkin()->link( $pageTitle, $pageTitle->getPrefixedText() );
183183 foreach ( $wgArticleFeedbackRatings as $category ) {
184184 $row[] = array(
185185 'attr' => in_array( $category, $page['categories'] )

Follow-up revisions

RevisionCommit summaryAuthorDate
r87457Applies the same fix that r87454 did, but to the other 2 methods that had the...tparscal21:27, 4 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87271AFT Fixes...krinkle18:30, 2 May 2011

Comments

#Comment by Krinkle (talk | contribs)   16:49, 22 June 2011

This follows up on r87271.

Status & tagging log