| Index: trunk/phase3/includes/parser/LinkHolderArray.php |
| — | — | @@ -63,7 +63,7 @@ |
| 64 | 64 | unset( $nsLinks ); |
| 65 | 65 | unset( $entry ); |
| 66 | 66 | |
| 67 | | - foreach ( $this->interwikis as $key => &$entry ) { |
| | 67 | + foreach ( $this->interwikis as &$entry ) { |
| 68 | 68 | $entry['title'] = Title::newFromText( $entry['pdbk'] ); |
| 69 | 69 | } |
| 70 | 70 | unset( $entry ); |
| Index: trunk/phase3/includes/HTMLForm.php |
| — | — | @@ -1346,7 +1346,7 @@ |
| 1347 | 1347 | # If one of the options' 'name' is int(0), it is automatically selected. |
| 1348 | 1348 | # because PHP sucks and thinks int(0) == 'some string'. |
| 1349 | 1349 | # Working around this by forcing all of them to strings. |
| 1350 | | - foreach( $this->mParams['options'] as $key => &$opt ){ |
| | 1350 | + foreach( $this->mParams['options'] as &$opt ){ |
| 1351 | 1351 | if( is_int( $opt ) ){ |
| 1352 | 1352 | $opt = strval( $opt ); |
| 1353 | 1353 | } |
| Index: trunk/phase3/includes/Html.php |
| — | — | @@ -107,8 +107,8 @@ |
| 108 | 108 | * features might be added, like allowing arrays for the values of |
| 109 | 109 | * attributes like class= and media=. |
| 110 | 110 | * |
| 111 | | - * @param $element string The element's name, e.g., 'a' |
| 112 | | - * @param $attribs array Associative array of attributes, e.g., array( |
| | 111 | + * @param $element string The element's name, e.g., 'a' |
| | 112 | + * @param $attribs array Associative array of attributes, e.g., array( |
| 113 | 113 | * 'href' => 'http://www.mediawiki.org/' ). See expandAttributes() for |
| 114 | 114 | * further documentation. |
| 115 | 115 | * @param $contents string The raw HTML contents of the element: *not* |
| — | — | @@ -132,6 +132,12 @@ |
| 133 | 133 | /** |
| 134 | 134 | * Identical to rawElement(), but HTML-escapes $contents (like |
| 135 | 135 | * Xml::element()). |
| | 136 | + * |
| | 137 | + * @param $element string |
| | 138 | + * @param $attribs array |
| | 139 | + * @param $contents string |
| | 140 | + * |
| | 141 | + * @return string |
| 136 | 142 | */ |
| 137 | 143 | public static function element( $element, $attribs = array(), $contents = '' ) { |
| 138 | 144 | return self::rawElement( $element, $attribs, strtr( $contents, array( |
| — | — | @@ -145,6 +151,11 @@ |
| 146 | 152 | /** |
| 147 | 153 | * Identical to rawElement(), but has no third parameter and omits the end |
| 148 | 154 | * tag (and the self-closing '/' in XML mode for empty elements). |
| | 155 | + * |
| | 156 | + * @param $element string |
| | 157 | + * @param $attribs array |
| | 158 | + * |
| | 159 | + * @return string |
| 149 | 160 | */ |
| 150 | 161 | public static function openElement( $element, $attribs = array() ) { |
| 151 | 162 | global $wgHtml5, $wgWellFormedXml; |