r87457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87456‎ | r87457 | r87458 >
Date:21:27, 4 May 2011
Author:tparscal
Status:ok
Tags:
Comment:
Applies the same fix that r87454 did, but to the other 2 methods that had the same issue.
Modified paths:
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -92,7 +92,7 @@
9393 * @return String: HTML table of daily highs and lows
9494 */
9595 protected function renderDailyHighsAndLows() {
96 - global $wgOut, $wgArticleFeedbackRatings;
 96+ global $wgOut, $wgUser;
9797
9898 $rows = array();
9999 $pages = $this->getDailyHighsAndLows();
@@ -100,7 +100,7 @@
101101 foreach ( $pages as $page ) {
102102 $row = array();
103103 $pageTitle = Title::newFromId( $page['page'] );
104 - $row['page'] = Linker::link( $pageTitle, $pageTitle->getPrefixedText() );
 104+ $row['page'] = $wgUser->getSkin()->link( $pageTitle, $pageTitle->getPrefixedText() );
105105 foreach ( $page['ratings'] as $id => $value ) {
106106 $row[] = array(
107107 'text' => round( $value, 2 ),
@@ -138,13 +138,13 @@
139139 * @return String: HTML table of weekly most changed
140140 */
141141 protected function renderWeeklyMostChanged() {
142 - global $wgOut;
 142+ global $wgOut, $wgUser;
143143
144144 $rows = array();
145145 foreach ( $this->getWeeklyMostChanged() as $page ) {
146146 $row = array();
147147 $pageTitle = Title::newFromText( $page['page'] );
148 - $row['page'] = Linker::link( $pageTitle, $pageTitle->getPrefixedText() );
 148+ $row['page'] = $wgUser->getSkin()->link( $pageTitle, $pageTitle->getPrefixedText() );
149149 foreach ( $page['changes'] as $id => $value ) {
150150 $row[] = array(
151151 'text' => round( $value, 2 ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87454Using $wgUser->getSkin() to call link() instead of Linker:: - fixes backwards...tparscal21:20, 4 May 2011

Status & tagging log