r87274 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87273‎ | r87274 | r87275 >
Date:18:34, 2 May 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Follow-up r87271: Also load on purge (= view); getArticleId is 0 by default, returns false
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.dashboard.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
@@ -7,11 +7,12 @@
88 // Main namespace articles
99 mw.config.get( 'wgNamespaceNumber' ) === 0
1010 // Existing pages
11 - && mw.config.get( 'wgArticleId', 0 ) > 0
 11+ && mw.config.get( 'wgArticleId' ) > 0
1212 // View pages
13 - && ( mw.config.get( 'wgAction' ) == 'view' || mw.config.get( 'wgAction' ) == 'view' )
 13+ && ( mw.config.get( 'wgAction' ) == 'view' || mw.config.get( 'wgAction' ) == 'purge' )
1414 // Current revision
15 - && ( mw.util.getParamValue( 'diff' ) == null && mw.util.getParamValue( 'oldid' ) == null )
 15+ && mw.util.getParamValue( 'diff' ) == null
 16+ && mw.util.getParamValue( 'oldid' ) == null
1617 ) {
1718 var trackingBucket = mw.user.bucket(
1819 'ext.articleFeedback-tracking', mw.config.get( 'wgArticleFeedbackTracking' )
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.dashboard.css
@@ -31,10 +31,24 @@
3232 text-align: right;
3333 }
3434
 35+.articleFeedback-table-cell-score-1 {
 36+ background-color: #ffcc00;
 37+}
 38+
 39+
 40+.articleFeedback-table-cell-score-2,
3541 .articleFeedback-table-cell-bad {
3642 background-color: #ffcc99;
3743 }
3844
 45+.articleFeedback-table-cell-score-3 {
 46+ background-color: #99cc99;
 47+}
 48+
 49+.articleFeedback-table-cell-score-4,
3950 .articleFeedback-table-cell-good {
4051 background-color: #99ff99;
4152 }
 53+.articleFeedback-table-cell-score-5 {
 54+ background-color: #00ff00;
 55+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r87695[AFT] Remove colors from scores on Special:ArticleFeedback Dashboard, add yet...krinkle20:29, 8 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87271AFT Fixes...krinkle18:30, 2 May 2011

Comments

#Comment by DieBuche (talk | contribs)   13:18, 2 July 2011

Colors reverted in r87695

Status & tagging log