r87695 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87694‎ | r87695 | r87696 >
Date:20:29, 8 May 2011
Author:krinkle
Status:ok
Tags:
Comment:
[AFT] Remove colors from scores on Special:ArticleFeedback Dashboard, add yet to phrasing of message. Sounds less like an error.
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.dashboard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.dashboard.css
@@ -31,6 +31,12 @@
3232 text-align: right;
3333 }
3434
 35+/**
 36+ * Per ArticleFeedback meeting of 2011-05-06,
 37+ * disable colors for now. We may re-enable them
 38+ * later if found useful.
 39+ */
 40+/*
3541 .articleFeedback-table-column-score-0,
3642 .articleFeedback-table-column-score-1 {
3743 background-color: #ffcccc;
@@ -53,3 +59,12 @@
5460 .articleFeedback-table-column-score-5 {
5561 background-color: #55ff55;
5662 }
 63+*/
 64+
 65+.articleFeedback-table-column-bad {
 66+ background-color: #ffcc99;
 67+}
 68+
 69+.articleFeedback-table-column-good {
 70+ background-color: #99ff99;
 71+}
\ No newline at end of file
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -43,7 +43,7 @@
4444 'articlefeedback-form-panel-helpimprove-privacy' => 'Privacy policy',
4545 'articlefeedback-form-panel-helpimprove-privacylink' => 'Project:Privacy policy',
4646 'articlefeedback-form-panel-submit' => 'Submit ratings',
47 - 'articlefeedback-form-panel-pending' => 'Your ratings have not been submitted',
 47+ 'articlefeedback-form-panel-pending' => 'Your ratings have not been submitted yet',
4848 'articlefeedback-form-panel-success' => 'Saved successfully',
4949 'articlefeedback-form-panel-expiry-title' => 'Your ratings have expired',
5050 'articlefeedback-form-panel-expiry-message' => 'Please reevaluate this page and submit new ratings.',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87274Follow-up r87271: Also load on purge (= view); getArticleId is 0 by default, ...krinkle18:34, 2 May 2011
r87276Fix colours (use same color range as cell-bad and cell-good); + apply to aver...krinkle18:47, 2 May 2011

Status & tagging log