r86004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86003‎ | r86004 | r86005 >
Date:23:16, 13 April 2011
Author:platonides
Status:ok
Tags:
Comment:
Add a couple of broken tests showing why having the table closing tags in the same line is not a good idea.
Modified paths:
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
@@ -1426,6 +1426,38 @@
14271427 !! end
14281428
14291429 !! test
 1430+A table with a caption with unclosed italic
 1431+!! input
 1432+{|
 1433+|+ ''caption
 1434+| Cell
 1435+|}
 1436+!! result
 1437+<table>
 1438+<caption><i>caption</i></caption>
 1439+<tr>
 1440+<td>Cell</td>
 1441+</tr>
 1442+</table>
 1443+
 1444+!! end
 1445+
 1446+!! test
 1447+A table with unclosed italic in a cell
 1448+!! input
 1449+{|
 1450+| ''Cell
 1451+|}
 1452+!! result
 1453+<table>
 1454+<tr>
 1455+<td><i>Cell</i></td>
 1456+</tr>
 1457+</table>
 1458+
 1459+!! end
 1460+
 1461+!! test
14301462 Table security: embedded pipes (http://lists.wikimedia.org/mailman/htdig/wikitech-l/2006-April/022293.html)
14311463 !! input
14321464 {|

Follow-up revisions

RevisionCommit summaryAuthorDate
r86005Follow up r85922 moving the </caption> to another line, fixing one of the tes...platonides23:19, 13 April 2011
r86010Another evil test to join r86004 (didn't produce malformed output in the pre-...platonides23:36, 13 April 2011
r86013Move </td> and </th> to its own line (unless it's an empty cell)...platonides23:50, 13 April 2011

Status & tagging log