r86005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86004‎ | r86005 | r86006 >
Date:23:19, 13 April 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow up r85922 moving the </caption> to another line, fixing one of the tests added in r86004.
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
@@ -1237,7 +1237,8 @@
12381238 |}
12391239 !! result
12401240 <table>
1241 -<caption>caption</caption>
 1241+<caption>caption
 1242+</caption>
12421243 <tr><td></td></tr>
12431244 </table>
12441245
@@ -1290,7 +1291,8 @@
12911292 |}
12921293 !! result
12931294 <table border="1" cellpadding="2">
1294 -<caption>Multiplication table</caption>
 1295+<caption>Multiplication table
 1296+</caption>
12951297 <thead>
12961298 <tr>
12971299 <th>&#215;</th>
@@ -1434,7 +1436,8 @@
14351437 |}
14361438 !! result
14371439 <table>
1438 -<caption><i>caption</i></caption>
 1440+<caption><i>caption</i>
 1441+</caption>
14391442 <tr>
14401443 <td>Cell</td>
14411444 </tr>
Index: trunk/phase3/includes/parser/Parser.php
@@ -1030,7 +1030,7 @@
10311031 $return .= isset( $table['caption']['attributes'] ) ? $table['caption']['attributes'] : '';
10321032 $return .= '>';
10331033 $return .= $table['caption']['content'];
1034 - $return .= '</caption>';
 1034+ $return .= "\n</caption>";
10351035 }
10361036 $lastSection = '';
10371037 $empty = true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85922diebuche21:27, 12 April 2011
r86004Add a couple of broken tests showing why having the table closing tags in the...platonides23:16, 13 April 2011

Status & tagging log