r86003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86002‎ | r86003 | r86004 >
Date:23:13, 13 April 2011
Author:laner
Status:deferred
Tags:
Comment:
Minor fixes for compatibility with cactus release of nova, and current release of the aws-sdk.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaController.php (modified) (history)
  • /trunk/extensions/OpenStackManager/OpenStackNovaImage.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaImage.php
@@ -27,7 +27,7 @@
2828 * @return string
2929 */
3030 function getImageId() {
31 - return (string)$this->image->id;
 31+ return (string)$this->image->imageId;
3232 }
3333
3434 /**
Index: trunk/extensions/OpenStackManager/OpenStackNovaController.php
@@ -384,6 +384,7 @@
385385 # recommended method of adding security group rules. When lp704645 is fixed, switch
386386 # to using this method.
387387 $rule = array();
 388+ $rule['GroupName'] = $groupname;
388389 if ( $fromport ) {
389390 $rule['FromPort'] = $fromport;
390391 }
@@ -407,8 +408,8 @@
408409 }
409410 }
410411 #$permissions = array( 'IpPermissions' => array( $rule ) );
411 - #$response = $this->novaConnection->authorize_security_group_ingress( $groupname, $permissions );
412 - $response = $this->novaConnection->authorize_security_group_ingress( $groupname, $rule );
 412+ #$response = $this->novaConnection->authorize_security_group_ingress( $permissions );
 413+ $response = $this->novaConnection->authorize_security_group_ingress( $rule );
413414
414415 return $response->isOK();
415416 }
@@ -427,6 +428,7 @@
428429 # recommended method of removing security group rules. When lp704645 is fixed, switch
429430 # to using this method.
430431 $rule = array();
 432+ $rule['GroupName'] = $groupname;
431433 if ( $fromport ) {
432434 $rule['FromPort'] = $fromport;
433435 }
@@ -450,8 +452,8 @@
451453 }
452454 }
453455 #$permissions = array( 'IpPermissions' => array( $rule ) );
454 - #$response = $this->novaConnection->revoke_security_group_ingress( $groupname, $permissions );
455 - $response = $this->novaConnection->revoke_security_group_ingress( $groupname, $rule );
 456+ #$response = $this->novaConnection->revoke_security_group_ingress( $permissions );
 457+ $response = $this->novaConnection->revoke_security_group_ingress( $rule );
456458 return $response->isOK();
457459 }
458460
Index: trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php
@@ -589,7 +589,7 @@
590590 }
591591 # TODO: also add puppet
592592 } else {
593 - $wgOut->addWikiMsg( 'openstackmanager-createeinstancefailed' );
 593+ $wgOut->addWikiMsg( 'openstackmanager-createinstancefailed' );
594594 }
595595 $sk = $wgOut->getSkin();
596596 $out = '<br />';

Status & tagging log