r85152 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85151‎ | r85152 | r85153 >
Date:20:48, 1 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Added charset property to HTTP Content-Type fields when serving CSS and JavaScript via ResourceLoader - resolves bug #28208.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoader.php
@@ -360,9 +360,9 @@
361361 wfProfileOut( __METHOD__.'-getModifiedTime' );
362362
363363 if ( $context->getOnly() === 'styles' ) {
364 - header( 'Content-Type: text/css' );
 364+ header( 'Content-Type: text/css; charset=utf-8' );
365365 } else {
366 - header( 'Content-Type: text/javascript' );
 366+ header( 'Content-Type: text/javascript; charset=utf-8' );
367367 }
368368 header( 'Last-Modified: ' . wfTimestamp( TS_RFC2822, $mtime ) );
369369 if ( $context->getDebug() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r852561.17wmf1: MFT r80813, r80815, r83798, r84459, r84729, r84820, r84921, r84985,...catrope14:13, 3 April 2011
r85435MFT: r84431, r84464, r84543, r84553, r84573, r84574, r84577, r84729, r84765, ...demon14:00, 5 April 2011

Status & tagging log