r80815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80814‎ | r80815 | r80816 >
Date:14:34, 23 January 2011
Author:krinkle
Status:ok
Tags:
Comment:
Follow-up per r80813 CR
Modified paths:
  • /trunk/phase3/includes/parser/CoreParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/CoreParserFunctions.php
@@ -619,15 +619,17 @@
620620 public static function filepath( $parser, $name='', $argA='', $argB='' ) {
621621 $file = wfFindFile( $name );
622622 $size = '';
 623+ $argA_int = intval( $argA );
 624+ $argB_int = intval( $argB );
623625
624 - if ( intval( $argB ) > 0 ) {
 626+ if ( $argB_int > 0 ) {
625627 // {{filepath: | option | size }}
626 - $size = intval( $argB );
 628+ $size = $argB_int;
627629 $option = $argA;
628630
629 - } elseif ( intval( $argA ) > 0 ) {
 631+ } elseif ( $argA_int > 0 ) {
630632 // {{filepath: | size [|option] }}
631 - $size = intval( $argA );
 633+ $size = $argA_int;
632634 $option = $argB;
633635
634636 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r852561.17wmf1: MFT r80813, r80815, r83798, r84459, r84729, r84820, r84921, r84985,...catrope14:13, 3 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80813Bug 26870 - add width/height param to {{filepath:}}...krinkle13:09, 23 January 2011

Status & tagging log