r85140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85139‎ | r85140 | r85141 >
Date:18:05, 1 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Fixed issue where reference error can be thrown - response to comments on r84985
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -720,7 +720,7 @@
721721 } catch ( e ) {
722722 // This needs to NOT use mw.log because these errors are common in production mode
723723 // and not in debug mode, such as when a symbol that should be global isn't exported
724 - if ( console && typeof console.log === 'function' ) {
 724+ if ( window.console && typeof window.console.log === 'function' ) {
725725 console.log( _fn + 'Exception thrown by ' + module + ': ' + e.message );
726726 console.log( e );
727727 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r852561.17wmf1: MFT r80813, r80815, r83798, r84459, r84729, r84820, r84921, r84985,...catrope14:13, 3 April 2011
r85435MFT: r84431, r84464, r84543, r84553, r84573, r84574, r84577, r84729, r84765, ...demon14:00, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84985Swtiched to using console.log if present so that when errors occur inside of ...tparscal22:08, 29 March 2011

Status & tagging log