r85110 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r85109‎ | r85110 | r85111 >
Date:09:35, 1 April 2011
Author:purodha
Status:resolved (Comments)
Tags:
Comment:
Add optional PLURAL parameter to messages 'userrights-changeable-col' and 'userrights-unchangeable-col'
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
——@@ -537,7 +537,7 @@
538538 foreach( $columns as $name => $column ) {
539539 if( $column === array() )
540540 continue;
541 - $ret .= Xml::element( 'th', null, wfMsg( 'userrights-' . $name . '-col' ) );
 541+ $ret .= Xml::element( 'th', null, wfMessage( 'userrights-' . $name . '-col', count( $column ) )->parse() );
542542 }
543543 $ret.= "</tr>\n<tr>\n";
544544 foreach( $columns as $column ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r85111Messages 'userrights-changeable-col' and 'userrights-unchangeable-col' got op...purodha09:38, 1 April 2011
r85114Fix r85110, see code review...purodha10:46, 1 April 2011

Comments

#Comment by IAlex (talk | contribs)   09:39, 1 April 2011

Do not pass a parsed string to Xml::element(); either use Html::rawElement() or Message::text() (but not both).

#Comment by Purodha (talk | contribs)   10:48, 1 April 2011

Done with r85114.

Status & tagging log