r85109 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85108‎ | r85109 | r85110 >
Date:09:35, 1 April 2011
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
Moved constant initialisation to class definition instead of constructor
Modified paths:
  • /trunk/phase3/includes/MagicWord.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MagicWord.php
@@ -30,9 +30,13 @@
3131 /**#@+
3232 * @private
3333 */
34 - var $mId, $mSynonyms, $mCaseSensitive, $mRegex;
35 - var $mRegexStart, $mBaseRegex, $mVariableRegex;
36 - var $mModified, $mFound;
 34+ var $mId, $mSynonyms, $mCaseSensitive;
 35+ var $mRegex = '';
 36+ var $mRegexStart = '';
 37+ var $mBaseRegex = '';
 38+ var $mVariableRegex = '';
 39+ var $mModified = false;
 40+ var $mFound = false;
3741
3842 static public $mVariableIDsInitialised = false;
3943 static public $mVariableIDs = array(
@@ -182,11 +186,6 @@
183187 $this->mId = $id;
184188 $this->mSynonyms = (array)$syn;
185189 $this->mCaseSensitive = $cs;
186 - $this->mRegex = '';
187 - $this->mRegexStart = '';
188 - $this->mVariableRegex = '';
189 - $this->mVariableStartToEndRegex = '';
190 - $this->mModified = false;
191190 }
192191
193192 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r86859Add |alt= option for galleries ( Bug 18682 ). Recommit of r86749, with nested...diebuche13:51, 25 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   00:03, 22 June 2011

mVariableStartToEndRegex got left out, but was fixed in r86859.

Status & tagging log