r85114 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r85113‎ | r85114 | r85115 >
Date:10:46, 1 April 2011
Author:purodha
Status:resolved (Comments)
Tags:
Comment:
Fix r85110, see code review
at http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85110
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
——@@ -537,7 +537,7 @@
538538 foreach( $columns as $name => $column ) {
539539 if( $column === array() )
540540 continue;
541 - $ret .= Xml::element( 'th', null, wfMessage( 'userrights-' . $name . '-col', count( $column ) )->parse() );
 541+ $ret .= Xml::rawElement( 'th', null, wfMessage( 'userrights-' . $name . '-col', count( $column ) )->parse() );
542542 }
543543 $ret.= "</tr>\n<tr>\n";
544544 foreach( $columns as $column ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r85115Fix for r85114, see code reviev...purodha11:28, 1 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85110Add optional PLURAL parameter to messages 'userrights-changeable-col' and 'us...purodha09:35, 1 April 2011

Comments

#Comment by IAlex (talk | contribs)   10:50, 1 April 2011

Read my previous comment once more, I didn't write Xml::rawElement(), but Html::rawElement(). Now I get Fatal error: Call to undefined method Xml::rawElement() in includes/specials/SpecialUserrights.php on line 540.

#Comment by Purodha (talk | contribs)   11:30, 1 April 2011

Fixed in r85115 now.

Status & tagging log