r84798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84797‎ | r84798 | r84799 >
Date:13:27, 26 March 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Follow-up r83336, r83460: abandon hardcoded styles altogether, and instead use a semantic element to pick up appropriate styles which are already in the global stylesheets. This makes it easier to keep track of where we have implemented this browser-specific tweak in case we have to modify it in future. By turning debugging on devs have already volunteered themselves to masses of gratuitous extra text-on-page, a few extra elements won't inconvenience them too much further.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -827,7 +827,7 @@
828828
829829 if ( $wgShowDebug ) {
830830 $listInternals = $this->formatDebugHTML( $out->mDebugtext );
831 - return "\n<hr />\n<strong>Debug data:</strong><ul style=\"font-family:'Courier New',monospace;\" id=\"mw-debug-html\">" .
 831+ return "\n<hr />\n<strong>Debug data:</strong><ul id=\"mw-debug-html\">" .
832832 $listInternals . "</ul>\n";
833833 }
834834
@@ -874,7 +874,7 @@
875875 } else {
876876 $ret .= str_repeat( "<ul><li>\n", $diff );
877877 }
878 - $ret .= $display . "\n";
 878+ $ret .= "<tt>$display</tt>\n";
879879
880880 $curIdent = $ident;
881881 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83336Use 'Courier new' for $wgShowDebug HTML output...hashar22:26, 5 March 2011
r83460Keep monospace as a fallback for HTML debugging...hashar16:36, 7 March 2011

Comments

#Comment by 😂 (talk | contribs)   14:34, 26 March 2011

!hss

#Comment by 😂 (talk | contribs)   14:34, 26 March 2011

!hss

Status & tagging log