r84799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84798‎ | r84799 | r84800 >
Date:15:18, 26 March 2011
Author:purodha
Status:resolved (Comments)
Tags:
Comment:
Minor: removed some typos in comment lines.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -5,16 +5,16 @@
66
77 /**
88 * This class should be covered by a general architecture document which does
9 - * not exist as of january 2011. This is one of the Core class and should
 9+ * not exist as of January 2011. This is one of the Core classes and should
1010 * be read at least once by any new developers.
1111 *
1212 * This class is used to prepare the final rendering. A skin is then
1313 * applied to the output parameters (links, javascript, html, categories ...).
1414 *
15 - * Another class (fixme) handle sending the whole page to the client.
 15+ * Another class (fixme) handles sending the whole page to the client.
1616 *
1717 * Some comments comes from a pairing session between Zak Greant and Ashar Voultoiz
18 - * in november 2010.
 18+ * in November 2010.
1919 *
2020 * @todo document
2121 */
@@ -37,9 +37,9 @@
3838 var $mBodytext = '';
3939
4040 /**
41 - * Holds the debug lines that will be outputted as comments in page source if
 41+ * Holds the debug lines that will be outputt as comments in page source if
4242 * $wgDebugComments is enabled. See also $wgShowDebug.
43 - * TODO: make a getter method for this
 43+ * TODO: make a better method for this
4444 */
4545 public $mDebugtext = ''; // TODO: we might want to replace it by wfDebug() wfDebugLog()
4646
@@ -68,7 +68,7 @@
6969
7070 /**
7171 * mLastModified and mEtag are used for sending cache control.
72 - * The whole caching system should probably be moved in its own class.
 72+ * The whole caching system should probably be moved into its own class.
7373 */
7474 var $mLastModified = '';
7575
@@ -76,8 +76,8 @@
7777 * Should be private. No getter but used in sendCacheControl();
7878 * Contains an HTTP Entity Tags (see RFC 2616 section 3.13) which is used
7979 * as a unique identifier for the content. It is later used by the client
80 - * to compare its cache version with the server version. Client sends
81 - * headers If-Match and If-None-Match containing its local cache ETAG value.
 80+ * to compare its cached version with the server version. Client sends
 81+ * headers If-Match and If-None-Match containing its locally cached ETAG value.
8282 *
8383 * To get more information, you will have to look at HTTP1/1 protocols which
8484 * is properly described in RFC 2616 : http://tools.ietf.org/html/rfc2616

Follow-up revisions

RevisionCommit summaryAuthorDate
r84999Fix new typos introduced in r84799.purodha06:35, 30 March 2011

Comments

#Comment by Platonides (talk | contribs)   16:35, 29 March 2011

Both outputted and output seem to be right [1]. However, you left it at an intermediate stage (outputt).

#Comment by MaxSem (talk | contribs)   16:40, 29 March 2011
-	 * TODO: make a getter method for this
+	 * TODO: make a better method for this

No, getter is exactly what it intended to mean.

#Comment by Purodha (talk | contribs)   06:36, 30 March 2011

Thanks, fixed in r84999.

Status & tagging log