r83460 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83459‎ | r83460 | r83461 >
Date:16:36, 7 March 2011
Author:hashar
Status:resolved
Tags:
Comment:
Keep monospace as a fallback for HTML debugging

Per CR on r83336. We also keep this as inline style since it is only
needed by developers anyway.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -827,7 +827,7 @@
828828
829829 if ( $wgShowDebug ) {
830830 $listInternals = $this->formatDebugHTML( $out->mDebugtext );
831 - return "\n<hr />\n<strong>Debug data:</strong><ul style=\"font-family:\'Courier New\';\" id=\"mw-debug-html\">" .
 831+ return "\n<hr />\n<strong>Debug data:</strong><ul style=\"font-family:\'Courier New\',monospace;\" id=\"mw-debug-html\">" .
832832 $listInternals . "</ul>\n";
833833 }
834834

Follow-up revisions

RevisionCommit summaryAuthorDate
r84798Follow-up r83336, r83460: abandon hardcoded styles altogether, and instead us...happy-melon13:27, 26 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83336Use 'Courier new' for $wgShowDebug HTML output...hashar22:26, 5 March 2011

Status & tagging log