r84598 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84597‎ | r84598 | r84599 >
Date:16:01, 23 March 2011
Author:aaron
Status:ok
Tags:
Comment:
Fixed reparse bug in buildQuickReview() due to comparison weakness
Modified paths:
  • /trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
@@ -642,7 +642,7 @@
643643 */
644644 public static function buildQuickReview(
645645 User $user, FlaggedArticle $article, Revision $rev,
646 - $refId = 0, $topNotice = '', $templateIDs, $imageSHA1Keys
 646+ $refId = 0, $topNotice = '', array $templateIDs = null, array $imageSHA1Keys = null
647647 ) {
648648 global $wgOut, $wgLang, $wgParser, $wgEnableParserCache;
649649 $id = $rev->getId();
@@ -745,7 +745,7 @@
746746 }
747747
748748 # Do we need to get inclusion IDs from parser output?
749 - if ( !$templateIDs || !$imageSHA1Keys ) {
 749+ if ( $templateIDs === null || $imageSHA1Keys === null ) {
750750 $pOutput = false;
751751 # Current version: try parser cache
752752 if ( $rev->isCurrent() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r84599MFT r84598demon16:12, 23 March 2011
r85033MFT more extension revs: r82601, r82654, r82698, r82755, r82756, r82759, r829...demon18:49, 30 March 2011

Status & tagging log