r84599 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84598‎ | r84599 | r84600 >
Date:16:12, 23 March 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r84598
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/FlaggedRevs/forms/RevisionReviewForm.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/FlaggedRevs/forms/RevisionReviewForm.php
@@ -642,7 +642,7 @@
643643 */
644644 public static function buildQuickReview(
645645 User $user, FlaggedArticle $article, Revision $rev,
646 - $refId = 0, $topNotice = '', $templateIDs, $imageSHA1Keys
 646+ $refId = 0, $topNotice = '', array $templateIDs = null, array $imageSHA1Keys = null
647647 ) {
648648 global $wgOut, $wgParser, $wgEnableParserCache;
649649 $id = $rev->getId();
@@ -735,7 +735,7 @@
736736 }
737737
738738 # Do we need to get inclusion IDs from parser output?
739 - if ( !$templateIDs || !$imageSHA1Keys ) {
 739+ if ( $templateIDs === null || $imageSHA1Keys === null ) {
740740 $pOutput = false;
741741 # Current version: try parser cache
742742 if ( $rev->isCurrent() ) {
Property changes on: branches/wmf/1.17wmf1/extensions/FlaggedRevs/forms/RevisionReviewForm.php
___________________________________________________________________
Added: svn:mergeinfo
743743 Merged /branches/chad-pre-wmf-merge/extensions/FlaggedRevs/forms/RevisionReviewForm.php:r76925
744744 Merged /branches/wmf-deployment/extensions/FlaggedRevs/forms/RevisionReviewForm.php:r60970
745745 Merged /branches/wmf/1.16wmf4/extensions/FlaggedRevs/forms/RevisionReviewForm.php:r67177,69199,76243,77266
746746 Merged /trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php:r78027,78042,78044,78051,78092,78140,78142,78163,78166,78213,78226,78293,78319,78346,78517,78520,79872-79873,80297,83138,84598

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84598Fixed reparse bug in buildQuickReview() due to comparison weaknessaaron16:01, 23 March 2011

Status & tagging log