r84442 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84441‎ | r84442 | r84443 >
Date:11:00, 21 March 2011
Author:maxsem
Status:ok
Tags:
Comment:
Simplification for r84439
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php
@@ -60,7 +60,7 @@
6161
6262 $query = $pager->getQueryInfo();
6363
64 - $query['conds'][] = 'cr_id IN (' . $db->makeList( $params['revs'] ) . ')';
 64+ $query['conds']['cr_id'] = $params['revs'];
6565
6666 $revisions = $db->select( $query['tables'], $query['fields'], $query['conds'],
6767 __METHOD__, $query['options'], $query['join_conds'] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r845451.17wmf1: MFT r84439, r84442, fixes DB error in the coderevisions API modulecatrope19:29, 22 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77686Followup r77664, no need to build the list myselfreedy22:40, 3 December 2010
r84439Fixed SQL error when crrevs is providedmaxsem05:19, 21 March 2011

Status & tagging log