r84439 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r84438‎ \| r84439 \| r84440 >
Date:	05:19, 21 March 2011
Author:	maxsem
Status:	resolved (Comments)
Tags:
Comment:	Fixed SQL error when crrevs is provided
Modified paths:	/trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php
—	—	@@ -60,7 +60,7 @@
61	61
62	62	$query = $pager->getQueryInfo();
63	63
64		~~- $query['conds'][] = array( 'cr_id IN' => $params['revs'] );~~
	64	+ $query['conds'][] = 'cr_id IN (' . $db->makeList( $params['revs'] ) . ')';
65	65
66	66	$revisions = $db->select( $query['tables'], $query['fields'], $query['conds'],
67	67	__METHOD__, $query['options'], $query['join_conds'] );

Revision	Commit summary	Author	Date
r84442	Simplification for r84439	maxsem	11:00, 21 March 2011
r84545	1.17wmf1: MFT r84439, r84442, fixes DB error in the coderevisions API module	catrope	19:29, 22 March 2011

Revision	Commit summary	Author	Date
r77686	Followup r77664, no need to build the list myself	reedy	22:40, 3 December 2010

#Comment by Nikerabbit (talk | contribs) 07:53, 21 March 2011

What's wrong with?

$query['conds']['cr_id'] = $params['revs'];

#Comment by MaxSem (talk | contribs) 11:01, 21 March 2011

Thanks, fixed.

16:13, 23 March 2011 Catrope (talk | contribs) changed the tags for r84439 [removed: 1.17wmf1]
11:38, 21 March 2011 Reedy (talk | contribs) changed the status of r84439 [removed: new added: resolved]
05:20, 21 March 2011 MaxSem (talk | contribs) changed the tags for r84439 [removed: 1.17_wmf1 added: 1.17wmf1]
05:19, 21 March 2011 MaxSem (talk | contribs) changed the tags for r84439 [added: 1.17_wmf1]