r77686 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r77685‎ | r77686 | r77687 >
Date:22:40, 3 December 2010
Author:reedy
Status:ok
Tags:
Comment:
Followup r77664, no need to build the list myself
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php
@@ -58,11 +58,9 @@
5959 if ( $revsSet ) {
6060 $db = wfGetDB( DB_SLAVE );
6161
62 - $list = $db->makeList( $params['revs'] );
63 -
6462 $query = $pager->getQueryInfo();
6563
66 - $query['conds'][] = 'cr_id IN ( ' . $list . ' )';
 64+ $query['conds'][] = array( 'cr_id IN' => $params['revs'] );
6765
6866 $revisions = $db->select( $query['tables'], $query['fields'], $query['conds'],
6967 __METHOD__, $query['options'], $query['join_conds'] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r84439Fixed SQL error when crrevs is providedmaxsem05:19, 21 March 2011
r84442Simplification for r84439maxsem11:00, 21 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77664*(bug 26061) CodeReview API need to give info for a list of revisionsreedy15:32, 3 December 2010

Status & tagging log