r82596 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82595‎ | r82596 | r82597 >
Date:10:26, 22 February 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Merge r67177 from 1.16wmf4
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -732,7 +732,10 @@
733733 $sqlx = strtr( $sqlx, "\t\n", ' ' );
734734 global $wgRequestTime;
735735 $elapsed = round( microtime( true ) - $wgRequestTime, 3 );
736 - wfLogDBError( "Connection lost and reconnected after {$elapsed}s, query: $sqlx\n" );
 736+ if ( $elapsed < 300 ) {
 737+ # Not a database error to lose a transaction after a minute or two
 738+ wfLogDBError( "Connection lost and reconnected after {$elapsed}s, query: $sqlx\n" );
 739+ }
737740 $ret = $this->doQuery( $commentedSql );
738741 } else {
739742 wfDebug( "Failed\n" );
Property changes on: trunk/phase3/includes/db/Database.php
___________________________________________________________________
Modified: svn:mergeinfo
740743 Merged /branches/wmf/1.16wmf4/includes/db/Database.php:r67177

Follow-up revisions

RevisionCommit summaryAuthorDate
r85081MFT last round of db and installer changes: r81755, r82596, r85021, r85047, r...demon19:33, 31 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67177suppress "connection lost" errors for all the batch work thingsmidom05:56, 1 June 2010

Comments

#Comment by Bryan (talk | contribs)   11:34, 23 February 2011

300, a minute or two?

#Comment by Reedy (talk | contribs)   11:53, 23 February 2011

Blame Domas ;)

#Comment by Catrope (talk | contribs)   16:09, 23 February 2011

Untagging 1.17wmf1, was already merged in by the make-wmf-branch script.

Status & tagging log