r82597 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82596‎ | r82597 | r82598 >
Date:11:08, 22 February 2011
Author:ialex
Status:deferred
Tags:
Comment:
* Set the action to $wgScript since when have a <input> for the title parameter
* Send the form directly to the good title
Modified paths:
  • /trunk/extensions/Eval/Eval.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Eval/Eval.class.php
@@ -46,14 +46,14 @@
4747 }
4848
4949 public function execute() {
50 - global $wgOut, $wgTitle;
 50+ global $wgOut, $wgScript;
5151
5252 $wgOut->addHTML(
5353 Xml::openElement( 'form',
5454 array(
5555 'id' => 'specialeval',
5656 'method' => 'get',
57 - 'action' => $wgTitle->escapeLocalUrl()
 57+ 'action' => $wgScript
5858 )
5959 ) .
6060 # Gotta use open and close here to
@@ -95,7 +95,7 @@
9696 array(
9797 'type' => 'hidden',
9898 'name' => 'title',
99 - 'value' => 'Special:Eval'
 99+ 'value' => SpecialPage::getTitleFor( 'Eval' )->getPrefixedDBkey()
100100 ),
101101 ''
102102 ) .

Status & tagging log