r82362 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82361‎ | r82362 | r82363 >
Date:23:08, 17 February 2011
Author:aaron
Status:deferred
Tags:
Comment:
Removed $wgFlaggedRevsStylePath; use $wgExtensionAssetsPath instead
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -200,10 +200,6 @@
201201 $wgAddGroups['bureaucrat'][] = 'reviewer';
202202 $wgRemoveGroups['bureaucrat'][] = 'reviewer';
203203
204 -# URL location that has an /img subdirectory containing UI icons
205 -# Use a literal $wgScriptPath as a placeholder for the runtime value of $wgScriptPath
206 -$wgFlaggedRevsStylePath = '$wgScriptPath/extensions/FlaggedRevs/client';
207 -
208204 # How far the logs for overseeing quality revisions and depreciations go
209205 $wgFlaggedRevsOversightAge = 30 * 24 * 3600;
210206
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -357,12 +357,12 @@
358358 }
359359
360360 /**
361 - * Get the URL path to /client
 361+ * Get the URL path to /client (has JS, CSS, & icons)
362362 * @return string
363363 */
364364 public static function styleUrlPath() {
365 - global $wgFlaggedRevsStylePath, $wgScriptPath;
366 - return str_replace( '$wgScriptPath', $wgScriptPath, $wgFlaggedRevsStylePath );
 365+ global $wgExtensionAssetsPath;
 366+ return "$wgExtensionAssetsPath/FlaggedRevs/client";
367367 }
368368
369369 # ################ Permission functions #################

Status & tagging log