r83228 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83227‎ | r83228 | r83229 >
Date:18:40, 4 March 2011
Author:juliano
Status:deferred
Tags:
Comment:
Get rid of another Parser::clearState() (followup r82316).
Modified paths:
  • /trunk/extensions/Wikilog/WikilogItemPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/WikilogItemPager.php
@@ -93,14 +93,14 @@
9494 $this->mLimit = $wgWikilogExpensiveLimit;
9595
9696 # Check parser state, setup edit links.
97 - global $wgOut, $wgParser;
 97+ global $wgOut, $wgParser, $wgTitle;
9898 if ( $this->mIncluding ) {
9999 $popt = $wgParser->getOptions();
100100 } else {
101101 $popt = $wgOut->parserOptions();
102102
103103 # We will need a clean parser if not including.
104 - $wgParser->clearState();
 104+ $wgParser->startExternalParse( $wgTitle, $popt, Parser::OT_HTML );
105105 }
106106 $this->mShowEditLink = $popt->getEditSection();
107107 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82316Parser::clearState() is no longer safe in 1.17a (since r79129) if Parser...juliano02:05, 17 February 2011

Status & tagging log