r82215 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82214‎ | r82215 | r82216 >
Date:03:38, 16 February 2011
Author:mah
Status:resolved (Comments)
Tags:
Comment:
re r82181 remove min-height that doesn't work with IE6
Modified paths:
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImageGallery.php
@@ -288,7 +288,7 @@
289289
290290 # Set both fixed width and min-height.
291291 $thumbhtml = "\n\t\t\t".
292 - '<div class="thumb" style="width: ' .($this->mWidths+30).'px; min-height: ' .($this->mHeights+30).'px;">'
 292+ '<div class="thumb" style="width: ' .($this->mWidths+30).'px; height: ' .($this->mHeights+30).'px;">'
293293 # Auto-margin centering for block-level elements. Needed now that we have video
294294 # handlers since they may emit block-level elements as opposed to simple <img> tags.
295295 # ref http://css-discuss.incutio.com/?page=CenteringBlockElement

Follow-up revisions

RevisionCommit summaryAuthorDate
r82309followup r82181 and r82215 to fix the FIXME and botched fix for FIXME....mah23:21, 16 February 2011
r85151MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ...demon20:39, 1 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82181* (bug 27338) Gallery in 1.17 breaks for audio/video + ogghandler...mah19:39, 15 February 2011

Comments

#Comment by Kaldari (talk | contribs)   19:37, 4 July 2011

Subsequent revs have removed the height or min-height from the div completely. Marking resolved.

Status & tagging log