r82044 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82043‎ | r82044 | r82045 >
Date:00:04, 13 February 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
1.17wmf1: Forgot one in r81723 because it's been renamed in trunk
Modified paths:
  • /branches/wmf/1.17wmf1/resources/Resources.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/resources/Resources.php
——@@ -418,6 +418,8 @@
419419 'mediawiki.legacy.ajaxwatch' => array(
420420 'scripts' => 'skins/common/ajaxwatch.js',
421421 'dependencies' => 'mediawiki.legacy.wikibits',
 422+ 'remoteBasePath' => $GLOBALS['wgStylePath'],
 423+ 'localBasePath' => "{$GLOBALS['IP']}/skins",
422424 ),
423425 'mediawiki.legacy.block' => array(
424426 'scripts' => 'common/block.js',

Follow-up revisions

RevisionCommit summaryAuthorDate
r82084Fixes for r82044, r81723. Krinkle helped :)demon21:58, 13 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r817231.17wmf1: MFT r81719, r81721, r81722catrope12:15, 8 February 2011

Comments

#Comment by Krinkle (talk | contribs)   21:55, 13 February 2011 
PHP Warning:  filemtime() [<a href='function.filemtime'>function.filemtime</a>]: stat failed for /usr/local/apache/common/php-1.17/skins/skins/common/ajaxwatch.js in /usr/local/apache/common-local/php-1.17/includes/resourceloader/ResourceLoaderFileModule.php on line 363

r81723 added "remoteBasePath" and "localBasePath" but it also modified "skins/common/..." to "common/...". And legacy.enhancedchanges was also renamed in trunk.

Thanks ^demon for noticing it in the logs.

Status & tagging log