r82045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82044‎ | r82045 | r82046 >
Date:00:04, 13 February 2011
Author:platonides
Status:ok
Tags:
Comment:
Follow up r82021. Free the string after using it. This would not just be a temporal leak, would also repeat old errors with new ones.
Modified paths:
  • /trunk/php/wmerrors/wmerrors.c (modified) (history)

Diff [purge]

Index: trunk/php/wmerrors/wmerrors.c
——@@ -242,6 +242,7 @@
243243 WMERRORS_G(recursion_guard) = 2;
244244 php_stream_write(logfile_stream, WMERRORS_G(log_buffer).c, WMERRORS_G(log_buffer).len TSRMLS_CC);
245245 WMERRORS_G(recursion_guard) = 1;
 246+ smart_str_free( &WMERRORS_G(log_buffer) ); /* Free and reset the buffer */
246247 }
247248
248249 php_stream_close( logfile_stream );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82021wmerrors: Enable UDP support (already supported by Platonides's existing TCP ...catrope18:09, 12 February 2011

Status & tagging log