r82043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82042‎ | r82043 | r82044 >
Date:23:42, 12 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r82042
Modified paths:
  • /branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoader.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoader.php
@@ -380,7 +380,8 @@
381381 // Some clients send "timestamp;length=123". Strip the part after the first ';'
382382 // so we get a valid timestamp.
383383 $ims = $context->getRequest()->getHeader( 'If-Modified-Since' );
384 - if ( $ims !== false ) {
 384+ // Never send 304s in debug mode
 385+ if ( $ims !== false && !$context->getDebug() ) {
385386 $imsTS = strtok( $ims, ';' );
386387 if ( $mtime <= wfTimestamp( TS_UNIX, $imsTS ) ) {
387388 // There's another bug in ob_gzhandler (see also the comment at
Property changes on: branches/wmf/1.17wmf1/includes/resourceloader/ResourceLoader.php
___________________________________________________________________
Modified: svn:mergeinfo
388389 Merged /trunk/phase3/includes/resourceloader/ResourceLoader.php:r82042

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82042Never serve 304s from RL in debug mode. This causes inadvertent caching of de...catrope23:41, 12 February 2011

Status & tagging log