r81956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81955‎ | r81956 | r81957 >
Date:11:10, 11 February 2011
Author:demon
Status:ok
Tags:
Comment:
Fix for when random numbers are entered as wiki set ids. It guarded against 'blahblahblah' but not '123456'
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/CentralAuth/SpecialWikiSets.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/CentralAuth/SpecialWikiSets.php
@@ -42,8 +42,8 @@
4343 $this->buildMainView();
4444 }
4545 } else {
46 - if ( $subpage && !is_numeric( $subpage ) ) {
47 - $set = WikiSet::newFromName( $subpage );
 46+ if ( $subpage ) {
 47+ $set = is_numeric( $subpage ) ? WikiSet::newFromId( $subpage ) : WikiSet::newFromName( $subpage );
4848 if ( $set ) {
4949 $subpage = $set->getID();
5050 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r85009Merge changes from 1.17wmf1 during deployment period: r81760, r81761, r81954,...demon14:19, 30 March 2011
r85011One last deployment merge: r81956 to trunkdemon14:35, 30 March 2011

Status & tagging log