r81954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81953‎ | r81954 | r81955 >
Date:10:24, 11 February 2011
Author:demon
Status:ok
Tags:
Comment:
Remove /e from preg_replace. Never ever use it. It throws warnings on preg_replace_callback anyway
Modified paths:
  • /branches/wmf/1.17wmf1/languages/classes/LanguageEo.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/languages/classes/LanguageEo.php
@@ -45,7 +45,7 @@
4646 } else if ( strcasecmp( $in, 'UTF-8' ) == 0 && strcasecmp( $out, 'x' ) == 0 ) {
4747 # Double Xs only if they follow cxapelutaj literoj.
4848 return preg_replace_callback(
49 - '/((?:[cghjsu]|\xc4[\x88\x89\x9c\x9d\xa4\xa5\xb4\xb5]|\xc5[\x9c\x9d\xac\xad])x*)/ei',
 49+ '/((?:[cghjsu]|\xc4[\x88\x89\x9c\x9d\xa4\xa5\xb4\xb5]|\xc5[\x9c\x9d\xac\xad])x*)/i',
5050 array( $this, 'strrtuxCallback' ), $string );
5151 }
5252 return parent::iconv( $in, $out, $string );

Follow-up revisions

RevisionCommit summaryAuthorDate
r85009Merge changes from 1.17wmf1 during deployment period: r81760, r81761, r81954,...demon14:19, 30 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81760preg_replace_callback() expects an actual callbackdemon16:38, 8 February 2011

Status & tagging log