r85009 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85008‎ | r85009 | r85010 >
Date:14:19, 30 March 2011
Author:demon
Status:ok
Tags:
Comment:
Merge changes from 1.17wmf1 during deployment period: r81760, r81761, r81954, r81956, r81962, r82224, r82225
Modified paths:
  • /branches/REL1_17/extensions/CentralAuth/SpecialWikiSets.php (modified) (history)
  • /branches/REL1_17/extensions/FlaggedRevs (modified) (history)
  • /branches/REL1_17/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /branches/REL1_17/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /branches/REL1_17/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /branches/REL1_17/extensions/FlaggedRevs/client/flaggedrevs.css (modified) (history)
  • /branches/REL1_17/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php (modified) (history)
  • /branches/REL1_17/extensions/SiteMatrix/SiteMatrix.php (modified) (history)
  • /branches/REL1_17/phase3/includes/ChangesList.php (modified) (history)
  • /branches/REL1_17/phase3/languages/classes/LanguageEo.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/SiteMatrix/SiteMatrix.php
@@ -65,6 +65,7 @@
6666 $wgExtensionMessagesFiles['SiteMatrix'] = $dir . 'SiteMatrix.i18n.php';
6767 $wgExtensionAliasesFiles['SiteMatrix'] = $dir . 'SiteMatrix.alias.php';
6868
 69+$wgAutoloadClasses['SiteMatrix'] = $dir . 'SiteMatrix_body.php';
6970 $wgAutoloadClasses['SiteMatrixPage'] = $dir . 'SiteMatrix_body.php';
7071 $wgSpecialPages['SiteMatrix'] = 'SiteMatrixPage';
7172 $wgSpecialPageGroups['SiteMatrix'] = 'wiki';
Property changes on: branches/REL1_17/extensions/SiteMatrix/SiteMatrix.php
___________________________________________________________________
Added: svn:mergeinfo
7273 Merged /branches/wmf/1.17wmf1/extensions/SiteMatrix/SiteMatrix.php:r81761
Index: branches/REL1_17/extensions/CentralAuth/SpecialWikiSets.php
@@ -42,8 +42,8 @@
4343 $this->buildMainView();
4444 }
4545 } else {
46 - if ( $subpage && !is_numeric( $subpage ) ) {
47 - $set = WikiSet::newFromName( $subpage );
 46+ if ( $subpage ) {
 47+ $set = is_numeric( $subpage ) ? WikiSet::newFromId( $subpage ) : WikiSet::newFromName( $subpage );
4848 if ( $set ) {
4949 $subpage = $set->getID();
5050 } else {
Property changes on: branches/REL1_17/extensions/CentralAuth/SpecialWikiSets.php
___________________________________________________________________
Added: svn:mergeinfo
5151 Merged /branches/wmf/1.17wmf1/extensions/CentralAuth/SpecialWikiSets.php:r81956
Index: branches/REL1_17/extensions/FlaggedRevs/FlaggedRevs.php
@@ -205,8 +205,8 @@
206206 $wgRemoveGroups['bureaucrat'][] = 'reviewer';
207207
208208 # URL location for flaggedrevs.css and flaggedrevs.js
209 -# Use a literal $wgScriptPath as a placeholder for the runtime value of $wgScriptPath
210 -$wgFlaggedRevsStylePath = '$wgScriptPath/extensions/FlaggedRevs/client';
 209+# Use a literal $wgExtensionAssetsPath as a placeholder for the runtime value of $wgExtensionAssetsPath
 210+$wgFlaggedRevsStylePath = '$wgExtensionAssetsPath/FlaggedRevs/client';
211211
212212 # How far the logs for overseeing quality revisions and depreciations go
213213 $wgFlaggedRevsOversightAge = 30 * 24 * 3600;
@@ -250,7 +250,7 @@
251251 $wgAvailableRights[] = 'stablesettings';
252252
253253 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
254 -$wgFlaggedRevStyleVersion = 85;
 254+$wgFlaggedRevStyleVersion = 87;
255255
256256 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
257257
Index: branches/REL1_17/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -361,8 +361,8 @@
362362 * @return string
363363 */
364364 public static function styleUrlPath() {
365 - global $wgFlaggedRevsStylePath, $wgScriptPath;
366 - return str_replace( '$wgScriptPath', $wgScriptPath, $wgFlaggedRevsStylePath );
 365+ global $wgFlaggedRevsStylePath, $wgExtensionAssetsPath;
 366+ return str_replace( '$wgExtensionAssetsPath', $wgExtensionAssetsPath, $wgFlaggedRevsStylePath );
367367 }
368368
369369 # ################ Permission functions #################
Index: branches/REL1_17/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php
@@ -145,7 +145,7 @@
146146
147147 protected function feedTitle() {
148148 global $wgContLanguageCode, $wgSitename;
149 - $page = SpecialPage::getPage( 'problemchanges' );
 149+ $page = SpecialPage::getPage( 'ProblemChanges' );
150150 $desc = $page->getDescription();
151151 return "$wgSitename - $desc [$wgContLanguageCode]";
152152 }
Property changes on: branches/REL1_17/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php
___________________________________________________________________
Added: svn:mergeinfo
153153 Merged /branches/chad-pre-wmf-merge/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php:r76925
154154 Merged /branches/wmf/1.17wmf1/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php:r82224-82225
155155 Merged /trunk/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php:r78027,78042,78044,78051,78092,78140,78142,78163,78166,78213,78226,78293,78319,78346,78517,78520,79872-79873,80297
Index: branches/REL1_17/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -145,9 +145,9 @@
146146 'Watchlist', 'Recentchanges', 'Contributions', 'Recentchangeslinked' );
147147 foreach ( $spPages as $key ) {
148148 if ( $title->isSpecial( $key ) ) {
149 - global $wgScriptPath, $wgFlaggedRevsStylePath, $wgFlaggedRevStyleVersion;
150 - $stylePath = str_replace( '$wgScriptPath',
151 - $wgScriptPath, $wgFlaggedRevsStylePath );
 149+ global $wgExtensionAssetsPath, $wgFlaggedRevsStylePath, $wgFlaggedRevStyleVersion;
 150+ $stylePath = str_replace( '$wgExtensionAssetsPath',
 151+ $wgExtensionAssetsPath, $wgFlaggedRevsStylePath );
152152 $encCssFile = htmlspecialchars( "$stylePath/flaggedrevs.css?" .
153153 $wgFlaggedRevStyleVersion );
154154 $out->addExtensionStyle( $encCssFile );
Property changes on: branches/REL1_17/extensions/FlaggedRevs/FlaggedRevs.hooks.php
___________________________________________________________________
Modified: svn:mergeinfo
155155 Merged /branches/wmf/1.17wmf1/extensions/FlaggedRevs/FlaggedRevs.hooks.php:r82225
Index: branches/REL1_17/extensions/FlaggedRevs/client/flaggedrevs.css
@@ -38,6 +38,10 @@
3939 width: 100%;
4040 clear: both;
4141 }
 42+.rtl table.flaggedrevs_editnotice,
 43+.rtl table.flaggedrevs_viewnotice {
 44+ text-align: right;
 45+}
4246
4347 div.flaggedrevs_diffnotice,
4448 div.flaggedrevs_preview {
Property changes on: branches/REL1_17/extensions/FlaggedRevs
___________________________________________________________________
Modified: svn:mergeinfo
4549 Merged /branches/wmf/1.17wmf1/extensions/FlaggedRevs:r82225
Index: branches/REL1_17/phase3/includes/ChangesList.php
@@ -1121,6 +1121,7 @@
11221122 $this->insertComment( $r, $rcObj );
11231123 $this->insertRollback( $r, $rcObj );
11241124 # Tags
 1125+ $classes = explode( ' ', $classes );
11251126 $this->insertTags( $r, $rcObj, $classes );
11261127 # Show how many people are watching this if enabled
11271128 $r .= $this->numberofWatchingusers($rcObj->numberofWatchingusers);
Property changes on: branches/REL1_17/phase3/includes/ChangesList.php
___________________________________________________________________
Modified: svn:mergeinfo
11281129 Merged /branches/wmf/1.17wmf1/includes/ChangesList.php:r81962
Index: branches/REL1_17/phase3/languages/classes/LanguageEo.php
@@ -41,12 +41,12 @@
4242 if ( strcasecmp( $in, 'x' ) == 0 && strcasecmp( $out, 'utf-8' ) == 0 ) {
4343 return preg_replace_callback (
4444 '/([cghjsu]x?)((?:xx)*)(?!x)/i',
45 - 'strrtxuCallback', $string );
 45+ array( $this, 'strrtuxCallback' ), $string );
4646 } else if ( strcasecmp( $in, 'UTF-8' ) == 0 && strcasecmp( $out, 'x' ) == 0 ) {
4747 # Double Xs only if they follow cxapelutaj literoj.
4848 return preg_replace_callback(
49 - '/((?:[cghjsu]|\xc4[\x88\x89\x9c\x9d\xa4\xa5\xb4\xb5]|\xc5[\x9c\x9d\xac\xad])x*)/ei',
50 - 'strrtuxCallback', $string );
 49+ '/((?:[cghjsu]|\xc4[\x88\x89\x9c\x9d\xa4\xa5\xb4\xb5]|\xc5[\x9c\x9d\xac\xad])x*)/i',
 50+ array( $this, 'strrtuxCallback' ), $string );
5151 }
5252 return parent::iconv( $in, $out, $string );
5353 }
Property changes on: branches/REL1_17/phase3/languages/classes/LanguageEo.php
___________________________________________________________________
Added: svn:mergeinfo
5454 Merged /branches/REL1_15/phase3/languages/classes/LanguageEo.php:r51646
5555 Merged /branches/sqlite/languages/classes/LanguageEo.php:r58211-58321
5656 Merged /trunk/phase3/languages/classes/LanguageEo.php:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,81657,81833,82845,82847-82849
5757 Merged /branches/new-installer/phase3/languages/classes/LanguageEo.php:r43664-66004
5858 Merged /branches/wmf/1.17wmf1/languages/classes/LanguageEo.php:r81760,81954

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81760preg_replace_callback() expects an actual callbackdemon16:38, 8 February 2011
r817611.17wmf1: Unbreak SiteMatrix API by adding SiteMatrix class to autoloadercatrope16:38, 8 February 2011
r81954Remove /e from preg_replace. Never ever use it. It throws warnings on preg_re...demon10:24, 11 February 2011
r81956Fix for when random numbers are entered as wiki set ids. It guarded against '...demon11:10, 11 February 2011
r81962Commit my live hack. $classes should be an array or array_merge() will yell a...demon12:23, 11 February 2011
r82224Commit live hackdemon07:44, 16 February 2011
r822251.17wmf1: Commit FlaggedRevs live hacks to make it work with RL. None of thes...catrope08:01, 16 February 2011

Status & tagging log