r81854 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81853‎ | r81854 | r81855 >
Date:22:42, 9 February 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Explicitally define $fld_rights on all code paths
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -35,7 +35,6 @@
3636 * @ingroup API
3737 */
3838 class ApiQueryAllUsers extends ApiQueryBase {
39 -
4039 public function __construct( $query, $moduleName ) {
4140 parent::__construct( $query, $moduleName, 'au' );
4241 }
@@ -53,7 +52,7 @@
5453 $fld_rights = isset( $prop['rights'] );
5554 $fld_registration = isset( $prop['registration'] );
5655 } else {
57 - $fld_blockinfo = $fld_editcount = $fld_groups = $fld_registration = false;
 56+ $fld_blockinfo = $fld_editcount = $fld_groups = $fld_registration = $fld_rights = false;
5857 }
5958
6059 $limit = $params['limit'];

Follow-up revisions

RevisionCommit summaryAuthorDate
r85148MFT: r80495, r80610, r80765, r81177, r81490, r81692, r81707, r81729, r81765, ...demon20:11, 1 April 2011

Comments

#Comment by Krinkle (talk | contribs)   23:53, 9 February 2011

This commit fixes an E_NOTICE introduced in r79545.

Status & tagging log