r81712 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81711‎ | r81712 | r81713 >
Date:10:43, 8 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Fix ReaderFeedback, which was adding a <script> to the <head> in an ugly way
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/ReaderFeedback/ReaderFeedback.hooks.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/ReaderFeedback/ReaderFeedback.hooks.php
@@ -24,8 +24,7 @@
2525 // Add CSS
2626 $wgOut->addExtensionStyle( $encCssFile );
2727 // Add JS
28 - $head = "<script type=\"$wgJsMimeType\" src=\"$encJsFile\"></script>\n";
29 - $wgOut->addHeadItem( 'ReaderFeedback', $head );
 28+ $wgOut->addScriptFile( "$stylepath/readerfeedback.js?$wgFeedbackStyleVersion" );
3029
3130 return true;
3231 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r81713Merge r81712 from 1.17wmf1: fix ReaderFeedback extension, was adding a <scrip...catrope10:46, 8 February 2011

Status & tagging log