r81733 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81732‎ | r81733 | r81734 >
Date:12:42, 8 February 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Fix JS/CSS loading in ReaderFeedback, was totally broken
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/ReaderFeedback/ReaderFeedback.hooks.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/ReaderFeedback/ReaderFeedback.hooks.php
@@ -19,12 +19,12 @@
2020
2121 $stylePath = str_replace( '$wgScriptPath', $wgScriptPath, $wgFeedbackStylePath );
2222
23 - $encCssFile = htmlspecialchars( "$stylePath/readerfeedback.css?$wgFeedbackStyleVersion" );
24 - $encJsFile = htmlspecialchars( "$stylePath/readerfeedback.js?$wgFeedbackStyleVersion" );
 23+ $cssFile = "$stylePath/readerfeedback.css?$wgFeedbackStyleVersion";
 24+ $jsFile = "$stylePath/readerfeedback.js?$wgFeedbackStyleVersion";
2525 // Add CSS
26 - $wgOut->addExtensionStyle( $encCssFile );
 26+ $wgOut->addExtensionStyle( $cssFile );
2727 // Add JS
28 - $wgOut->addScriptFile( "$stylepath/readerfeedback.js?$wgFeedbackStyleVersion" );
 28+ $wgOut->addScriptFile( $jsFile );
2929
3030 return true;
3131 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r81734Merge r81733 from 1.17wmf1: rudimetary fixup of ReaderFeedback JS/CSS loading...catrope12:44, 8 February 2011

Status & tagging log