r81186 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81185‎ | r81186 | r81187 >
Date:09:00, 29 January 2011
Author:ialex
Status:reverted
Tags:
Comment:
* (bug 27016) Fix for r77638: dumpTextPass.php now consider the "output" parameter

Also added "output" parameter to the doc since nothing was mentioning it
Modified paths:
  • /trunk/phase3/maintenance/dumpTextPass.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/dumpTextPass.php
@@ -157,7 +157,7 @@
158158 $reader = new XMLReader();
159159 $reader->open( $this->input );
160160 $writer = new XMLWriter();
161 - $writer->openURI( 'php://stdout' );
 161+ $writer->openMemory();
162162
163163
164164 while ( $reader->read() ) {
@@ -216,8 +216,8 @@
217217 }
218218 $writer->text( $reader->value );
219219 }
 220+ $this->sink->write( $writer->outputMemory() );
220221 }
221 - $writer->flush();
222222 }
223223
224224 function getText( $id ) {
@@ -451,6 +451,8 @@
452452 --report=n Report position and speed after every n pages processed.
453453 (Default: 100)
454454 --server=h Force reading from MySQL server h
 455+ --output=<type>:<file> Write to a file instead of stdout
 456+ <type>s: file, gzip, bzip2, 7zip
455457 --current Base ETA on number of pages in database instead of all revisions
456458 --spawn Spawn a subprocess for loading text records
457459 --help Display this help message

Follow-up revisions

RevisionCommit summaryAuthorDate
r814111.17: MFT r81186, r81187, r81197, r81209, r81210, r81211, r81215, r81238, r81...catrope20:23, 2 February 2011
r92707Revert r85034, r81186, r77638: per CR on r77638: XMLReader and XMLWriter are ...demon23:06, 20 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r77638Modifier dumpTextPass.php to use XMLReader and XMLWriter rather than xml_* fu...ialex10:05, 3 December 2010

Status & tagging log