r81210 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r81209‎ | r81210 | r81211 >
Date:18:17, 30 January 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
(Bug 26961) hide anons from watchlist preference was broken due to typo in
r39314.

Fix by duplicatebug.

Given that this preference has been broken since it was introduced,
and the only person to notice in 3 years has been the testers, that may be
a good argument to remove the preference altogether.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialWatchlist.php
——@@ -103,7 +103,7 @@
104104 $prefs['days'] = floatval( $wgUser->getOption( 'watchlistdays' ) );
105105 $prefs['hideminor'] = $wgUser->getBoolOption( 'watchlisthideminor' );
106106 $prefs['hidebots'] = $wgUser->getBoolOption( 'watchlisthidebots' );
107 - $prefs['hideanons'] = $wgUser->getBoolOption( 'watchlisthideanon' );
 107+ $prefs['hideanons'] = $wgUser->getBoolOption( 'watchlisthideanons' );
108108 $prefs['hideliu'] = $wgUser->getBoolOption( 'watchlisthideliu' );
109109 $prefs['hideown' ] = $wgUser->getBoolOption( 'watchlisthideown' );
110110 $prefs['hidepatrolled' ] = $wgUser->getBoolOption( 'watchlisthidepatrolled' );
Index: trunk/phase3/RELEASE-NOTES
——@@ -107,6 +107,7 @@
108108 the right message instead of complaining about a MIME/extension mismatch
109109 * (bug 26809) Uploading files with multiple extensions where one of the extensions
110110 is blacklisted now gives the proper extension in the error message.
 111+* (bug 26961) Hide anon edits in watchlist preference now actually works.
111112
112113 === API changes in 1.18 ===
113114 * (bug 26339) Throw warning when truncating an overlarge API result

Follow-up revisions

RevisionCommit summaryAuthorDate
r814111.17: MFT r81186, r81187, r81197, r81209, r81210, r81211, r81215, r81238, r81...catrope20:23, 2 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39314(bug 15157) Special:Watchlist now has the same options as Special:Watchlist:...siebrand23:08, 13 August 2008

Comments

#Comment by Siebrand (talk | contribs)   19:28, 30 January 2011

Support for the suggested removal, as long as the UI is kept consistent with that of other lists (i.e. "hide anons" should be removed from other pages also).

#Comment by Krinkle (talk | contribs)   20:18, 30 January 2011

Hereby support not to remove the preference ;-)

Both RecentChanges and Watchilst have the options to hide/show: minor edits, bots, anons, logged-in users, 'own' and patrolled. Having to click these everytime when loading the watchlist or recent changes is annoying, hence the ability to set the preference to 'remember' this.

I would like to see similar preferences for RecentChanges (since those are currently incomplete, one can only set preferences to hide/show: minor edits and patrolled). Hiding bots, anons logged-in users and/or 'own' can not be saved through preferences for RecentChanges (which _can_ be done for Watchlist) and have to be clicked every time.

Requested in bug 27050.

#Comment by Nikerabbit (talk | contribs)   22:24, 30 January 2011

Can't we achieve the same result with bookmarks or cookies remembering the state of the switches. Having preferences for single special page hidden somewhere else feels silly.

Status & tagging log