r85034 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85033‎ | r85034 | r85035 >
Date:18:56, 30 March 2011
Author:reedy
Status:reverted
Tags:
Comment:
Swap = to == in conditional
Modified paths:
  • /trunk/phase3/maintenance/dumpTextPass.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/dumpTextPass.php
@@ -248,7 +248,7 @@
249249 } elseif ( $tag == 'page' ) {
250250 $state = 'page';
251251 }
252 - } elseif ( $type == XMLReader::SIGNIFICANT_WHITESPACE || $type = XMLReader::TEXT ) {
 252+ } elseif ( $type == XMLReader::SIGNIFICANT_WHITESPACE || $type == XMLReader::TEXT ) {
253253 if ( $lastName == 'id' ) {
254254 if ( $state == 'revision' ) {
255255 $this->thisRev .= $reader->value;

Follow-up revisions

RevisionCommit summaryAuthorDate
r92707Revert r85034, r81186, r77638: per CR on r77638: XMLReader and XMLWriter are ...demon23:06, 20 July 2011

Status & tagging log