r81164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r81163‎ | r81164 | r81165 >
Date:21:02, 28 January 2011
Author:demon
Status:resolved (Comments)
Tags:
Comment:
(bug 26939) $wgMetaNamespace is not being generated
Modified paths:
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -46,6 +46,7 @@
4747 'wgRightsText', 'wgRightsCode', 'wgMainCacheType', 'wgEnableUploads',
4848 'wgMainCacheType', '_MemCachedServers', 'wgDBserver', 'wgDBuser',
4949 'wgDBpassword', 'wgUseInstantCommons', 'wgUpgradeKey', 'wgDefaultSkin',
 50+ 'wgMetaNamespace'
5051 ),
5152 $db->getGlobalNames()
5253 );
@@ -171,6 +172,10 @@
172173
173174 $rights = $this->values['wgRightsUrl'] ? '' : '#';
174175 $hashedUploads = $this->safeMode ? '' : '#';
 176+ $metaNamespace = '';
 177+ if( $this->values['wgMetaNamespace'] !== $this->values['wgSitename'] ) {
 178+ $metaNamespace = "\$wgMetaNamespace = \"{$this->values['wgMetaNamespace']}\";\n";
 179+ }
175180
176181 switch( $this->values['wgMainCacheType'] ) {
177182 case 'anything':
@@ -205,8 +210,8 @@
206211 ## Uncomment this to disable output compression
207212 # \$wgDisableOutputCompression = true;
208213
209 -\$wgSitename = \"{$this->values['wgSitename']}\";
210 -
 214+\$wgSitename = \"{$this->values['wgSitename']}\";
 215+{$metaNamespace}
211216 ## The URL base path to the directory containing the wiki;
212217 ## defaults for all runtime URL paths are based off of this.
213218 ## For more information on customizing the URLs please see:
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -624,7 +624,7 @@
625625 $retVal = true;
626626 $this->parent->setVarsFromRequest( array( 'wgSitename', '_NamespaceType',
627627 '_AdminName', '_AdminPassword', '_AdminPassword2', '_AdminEmail',
628 - '_Subscribe', '_SkipOptional' ) );
 628+ '_Subscribe', '_SkipOptional', 'wgMetaNamespace' ) );
629629
630630 // Validate site name
631631 if ( strval( $this->getVar( 'wgSitename' ) ) === '' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r84403(bug 26939) Installer does not set $wgMetaNamespacemaxsem17:36, 20 March 2011

Comments

#Comment by 😂 (talk | contribs)   01:11, 29 January 2011

Is codurr back?

#Comment by MZMcBride (talk | contribs)   16:33, 29 January 2011

I think s3 replication is fixed now.

#Comment by Reedy (talk | contribs)   07:52, 30 January 2011

Leaving new pending bug 27036

#Comment by Hashar (talk | contribs)   06:54, 31 January 2011

... which deserves a 'fixme' status.

#Comment by 😂 (talk | contribs)   13:07, 31 January 2011

CLI installer is non-blocking, doesn't need a fixme.

#Comment by MZMcBride (talk | contribs)   00:09, 1 February 2011

Well, then I'll re-open bug 26939. It's fine to remove "fixme" if the goal really is to just get 1.17 deployed and all that, but if the code isn't actually fixed, there should be a relevant bug report.

#Comment by 😂 (talk | contribs)   00:12, 1 February 2011

This isn't about deployment. I consider the CLI installer to be non-blocking for the general 1.17 release.

#Comment by 😂 (talk | contribs)   00:29, 1 February 2011

Putting back to fixme.

Status & tagging log