r84403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84402‎ | r84403 | r84404 >
Date:17:36, 20 March 2011
Author:maxsem
Status:ok
Tags:
Comment:
(bug 26939) Installer does not set $wgMetaNamespace
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/installer/CliInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CliInstaller.php
@@ -44,6 +44,8 @@
4545 * @param $option Array
4646 */
4747 function __construct( $siteName, $admin = null, array $option = array() ) {
 48+ global $wgContLang;
 49+
4850 parent::__construct();
4951
5052 foreach ( $this->optionMap as $opt => $global ) {
@@ -54,7 +56,7 @@
5557 }
5658
5759 if ( isset( $option['lang'] ) ) {
58 - global $wgLang, $wgContLang, $wgLanguageCode;
 60+ global $wgLang, $wgLanguageCode;
5961 $this->setVar( '_UserLang', $option['lang'] );
6062 $wgContLang = Language::factory( $option['lang'] );
6163 $wgLang = Language::factory( $option['lang'] );
@@ -63,6 +65,12 @@
6466
6567 $this->setVar( 'wgSitename', $siteName );
6668
 69+ $metaNS = $wgContLang->ucfirst( str_replace( ' ', '_', $siteName ) );
 70+ if ( $metaNS == 'MediaWiki' ) {
 71+ $metaNS = 'Project';
 72+ }
 73+ $this->setVar( 'wgMetaNamespace', $metaNS );
 74+
6775 if ( $admin ) {
6876 $this->setVar( '_AdminName', $admin );
6977 }
Index: trunk/phase3/RELEASE-NOTES
@@ -198,8 +198,9 @@
199199 * (bug 28034) uploading file to local wiki when file exists on shared repository
200200 (commons) gives spurious info in the warning message
201201 * Usernames get lost when selecting different sorts on Special:listfiles
202 -* (Bug 14005) editing section 0 of an existing but empty page gives no such
 202+* (bug 14005) editing section 0 of an existing but empty page gives no such
203203 section error
 204+* (bug 26939) Installer does not set $wgMetaNamespace
204205
205206 === API changes in 1.18 ===
206207 * (bug 26339) Throw warning when truncating an overlarge API result

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81164(bug 26939) $wgMetaNamespace is not being generateddemon21:02, 28 January 2011

Status & tagging log