r80961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80960‎ | r80961 | r80962 >
Date:08:28, 25 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup whitespace issues from r75319

Yay crappy IDE artifacts, shouldn't occur in future...
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -96,7 +96,7 @@
9797 }
9898 }
9999
100 - return $allPaths;
 100+ return $allPaths;
101101 }
102102
103103 /**
@@ -455,7 +455,7 @@
456456 }
457457 }
458458 }
459 - return $affectedRevs;
 459+ return $affectedRevs;
460460 }
461461
462462 /**
@@ -479,7 +479,7 @@
480480 );
481481 $affectedBugs[] = intval( $bug );
482482 }
483 - $dbw->insert( 'code_bugs', $data, __METHOD__, array( 'IGNORE' ) );
 483+ $dbw->insert( 'code_bugs', $data, __METHOD__, array( 'IGNORE' ) );
484484 }
485485
486486 // Also, get previous revisions that have bugs in common...
@@ -500,7 +500,7 @@
501501 }
502502 }
503503
504 - return $affectedRevs;
 504+ return $affectedRevs;
505505 }
506506
507507 /**
Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
@@ -104,7 +104,7 @@
105105 if ( count( $removeReferences ) && $this->validPost( 'codereview-associate' ) ) {
106106 $this->mRev->removeReferencesFrom( $removeReferences );
107107 }
108 -
 108+
109109 // Add any comments
110110 $commentAdded = false;
111111 $commentId = 0;
@@ -112,7 +112,7 @@
113113 // $isPreview = $wgRequest->getCheck( 'wpPreview' );
114114 $commentId = $this->mRev->saveComment( $commentText, $review, $parent );
115115
116 - $commentAdded = ($commentId !== 0);
 116+ $commentAdded = ($commentId !== 0);
117117 }
118118 $dbw->commit();
119119
@@ -133,8 +133,8 @@
134134 $wgUser->getName(), $url, $this->mRev->getIdStringUnique(), $this->text
135135 );
136136 }
137 - }
 137+ }
138138
139 - return $commentId;
 139+ return $commentId;
140140 }
141141 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r810791.17: MFT r80507, r80634, r80770, r80961, r80978, r80985, r81042, r81060, r81...catrope01:15, 27 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75319* (bug 25628) Send email on revision state change. Some refactoring, invertin...reedy17:05, 24 October 2010

Status & tagging log