r80960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80959‎ | r80960 | r80961 >
Date:08:24, 25 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r79326, fixup wrong query, presumably copy paste artifact
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
@@ -1501,11 +1501,12 @@
15021502 $n = $row->count;
15031503 $dbr->freeResult( $res );
15041504 }
 1505+
15051506 // find the proofreading status of transclusions
15061507 $queryArr = array(
15071508 'tables' => array( 'templatelinks', 'page', 'categorylinks' ),
15081509 'fields' => array( 'COUNT(page_id) AS count' ),
1509 - 'conds' => array( 'cl_to' => '', 'page_namespace' => $page_ns_index, 'page_title' => $pages ),
 1510+ 'conds' => array( 'tl_from' => $id, 'tl_namespace' => $page_ns_index, 'cl_to' => '' ),
15101511 'joins' => array(
15111512 'page' => array( 'LEFT JOIN', 'page_title=tl_title AND page_namespace=tl_namespace' ),
15121513 'categorylinks' => array( 'LEFT JOIN', 'cl_from=page_id' ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79326Rewrite some of the Raw SQL buildingreedy04:53, 31 December 2010

Status & tagging log