r80985 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80984‎ | r80985 | r80986 >
Date:20:10, 25 January 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r75319, swap && for ||, only care about one being false to short circuit the early exit
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -576,7 +576,7 @@
577577 // Give email notices to committer and commenters
578578 global $wgCodeReviewENotif, $wgEnableEmail, $wgCodeReviewCommentWatcherEmail,
579579 $wgCodeReviewCommentWatcherName, $wgUser;
580 - if ( !$wgCodeReviewENotif && !$wgEnableEmail ) {
 580+ if ( !$wgCodeReviewENotif || !$wgEnableEmail ) {
581581 return;
582582 }
583583

Follow-up revisions

RevisionCommit summaryAuthorDate
r810791.17: MFT r80507, r80634, r80770, r80961, r80978, r80985, r81042, r81060, r81...catrope01:15, 27 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75319* (bug 25628) Send email on revision state change. Some refactoring, invertin...reedy17:05, 24 October 2010

Status & tagging log