r80792 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80791‎ | r80792 | r80793 >
Date:02:37, 23 January 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
adding links to other skins in mediaWiki JS test suite. (Previously making sure everything works in all skins was a PITA
Modified paths:
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
@@ -61,8 +61,18 @@
6262 // Build page
6363 document.title = 'mediaWiki JavaScript library test suite - ' + mw.config.get( 'wgSiteName' );
6464 $( '#firstHeading' ).text( 'mediaWiki JavaScript library test suite' );
 65+ var skinLinksText = 'Test in: ';
 66+ skinLinks = [],
 67+ availableSkins = mw.config.get( 'wgAvailableSkins' );
 68+ for ( skin in availableSkins ) {
 69+ skinLinks.push( mw.html.element( 'a', {
 70+ 'href': mw.util.wikiGetlink( wgPageName ) + '?action=mwutiltest&debug=true&useskin=' + encodeURIComponent( skin )
 71+ }, availableSkins[skin] ) );
 72+ }
 73+ skinLinksText += skinLinks.join( ' | ' ) + '.';
6574 mw.util.$content.html(
6675 '<p>Below is a list of tests to confirm proper functionality of the mediaWiki JavaScript library</p>'
 76+ + '<p>' + skinLinksText + '</p>'
6777 + '<hr />'
6878 + '<table id="mw-mwutiltest-table" class="wikitable sortable" style="white-space:break; font-family:monospace,\'Courier New\'">'
6979 + '<tr><th>Exec</th><th>Should return</th><th>Does return</th><th>Equal ?</th></tr>'

Follow-up revisions

RevisionCommit summaryAuthorDate
r87684mw.util.test update...krinkle13:22, 8 May 2011

Comments

#Comment by Krinkle (talk | contribs)   12:13, 23 January 2011

This is a bug in TWN's configuration. It works fine on the normal translatewiki:

http://translatewiki.net/wiki/Special:BlankPage?action=mwutiltest&debug=true -> http://translatewiki.net/wiki/Special:BlankPage?action=mwutiltest&debug=true&useskin=simple

"wgServer" is defined as "http://bits.translatewiki.net" in TWN's sandwiki

#Comment by Nikerabbit (talk | contribs)   14:40, 23 January 2011

Was fixed.

#Comment by He7d3r (talk | contribs)   14:28, 7 May 2011
wgPageName --> mw.config.get( 'wgPageName' )

Status & tagging log