r80791 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80790‎ | r80791 | r80792 >
Date:02:22, 23 January 2011
Author:krinkle
Status:ok
Tags:
Comment:
Obviously no need for a foreach loop here. (Follow-up r80790)
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php
@@ -49,11 +49,6 @@
5050 implode( "\t", $digitTransTable ),
5151 );
5252 $mainPage = Title::newMainPage();
53 - // Available skins by code and with display name
54 - $availableSkins = array();
55 - foreach ( Skin::getSkinNames() as $skinName => $skinDisplayName ) {
56 - $availableSkins[$skinName] = $skinDisplayName;
57 - }
5853
5954 // Build list of variables
6055 $vars = array(
@@ -85,7 +80,7 @@
8681 // This sucks, it is only needed on Special:Upload, but I could
8782 // not find a way to add vars only for a certain module
8883 'wgFileCanRotate' => BitmapHandler::canRotate(),
89 - 'wgAvailableSkins' => $availableSkins,
 84+ 'wgAvailableSkins' => Skin::getSkinNames(),
9085 );
9186 if ( $wgContLang->hasVariants() ) {
9287 $vars['wgUserVariant'] = $wgContLang->getPreferredVariant();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80790adding available skins to mw.config.valueskrinkle02:19, 23 January 2011

Status & tagging log