r80793 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80792‎ | r80793 | r80794 >
Date:02:48, 23 January 2011
Author:krinkle
Status:ok
Tags:
Comment:
'skin' sometimes interferes with the global.
Modified paths:
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.test.js
@@ -63,11 +63,12 @@
6464 $( '#firstHeading' ).text( 'mediaWiki JavaScript library test suite' );
6565 var skinLinksText = 'Test in: ';
6666 skinLinks = [],
67 - availableSkins = mw.config.get( 'wgAvailableSkins' );
68 - for ( skin in availableSkins ) {
 67+ availableSkins = mw.config.get( 'wgAvailableSkins' ),
 68+ skincode = '';
 69+ for ( skincode in availableSkins ) {
6970 skinLinks.push( mw.html.element( 'a', {
70 - 'href': mw.util.wikiGetlink( wgPageName ) + '?action=mwutiltest&debug=true&useskin=' + encodeURIComponent( skin )
71 - }, availableSkins[skin] ) );
 71+ 'href': mw.util.wikiGetlink( wgPageName ) + '?action=mwutiltest&debug=true&useskin=' + encodeURIComponent( skincode )
 72+ }, availableSkins[skincode] ) );
7273 }
7374 skinLinksText += skinLinks.join( ' | ' ) + '.';
7475 mw.util.$content.html(

Status & tagging log