r80692 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r80691‎ | r80692 | r80693 >
Date:17:23, 21 January 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix r80666: botched variable rename
Modified paths:
  • /trunk/phase3/includes/libs/JavaScriptDistiller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/JavaScriptDistiller.php
@@ -22,7 +22,7 @@
2323 $script = self::stripComments( $script );
2424 $script = self::stripHorizontalSpace( $script );
2525 // If requested, make some vertical whitespace collapsing as well
26 - if ( $collapseVertical ) {
 26+ if ( $stripVerticalSpace ) {
2727 $script = self::stripVerticalSpace( $script );
2828 }
2929 // Done

Follow-up revisions

RevisionCommit summaryAuthorDate
r810091.17: MFT r79839, r79862, r79863, r79895, r80003, r80005, r80164, r80692catrope00:20, 26 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r80666Addresses issues raised in an excellent review of r80656.tparscal00:03, 21 January 2011

Status & tagging log